Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should generate correct chunk import path to importee in importer chunk #1180

Conversation

hyf0
Copy link
Member

@hyf0 hyf0 commented May 20, 2024

Description

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.87%. Comparing base (4c6a63a) to head (be6ceb5).
Report is 5 commits behind head on main.

Current head be6ceb5 differs from pull request most recent head 3e815f7

Please upload reports for the commit 3e815f7 to get more accurate results.

Files Patch % Lines
crates/rolldown/src/bundler.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
+ Coverage   86.78%   86.87%   +0.09%     
==========================================
  Files         123      123              
  Lines        6143     6155      +12     
==========================================
+ Hits         5331     5347      +16     
+ Misses        812      808       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 20, 2024

Benchmarks Rust

  • target: 05-20-chore_rust_unite_using_filename_instead_of_file_name_(b7b815e)
  • pr: 05-21-fix_should_generate_correct_chunk_import_path_to_importee_in_importer_chunk(be6ceb5)
group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     30.4±0.56ms        ? ?/sec    1.05     32.0±0.68ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     21.4±0.93ms        ? ?/sec    1.04     22.2±0.80ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.01     43.1±1.07ms        ? ?/sec    1.00     42.6±1.40ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.02    325.8±2.29ms        ? ?/sec    1.00    320.2±2.73ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    210.7±2.73ms        ? ?/sec    1.00    209.7±1.37ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.01    458.8±9.67ms        ? ?/sec    1.00   454.9±10.79ms        ? ?/sec

Benchmarks Rust

  • target: main(9204e6d)
  • pr: 05-21-fix_should_generate_correct_chunk_import_path_to_importee_in_importer_chunk(3e815f7)
group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     30.4±1.03ms        ? ?/sec    1.00     30.4±0.62ms        ? ?/sec
rolldown benchmark/threejs-scan            1.01     21.3±1.49ms        ? ?/sec    1.00     21.1±0.45ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.02     43.3±3.60ms        ? ?/sec    1.00     42.4±0.98ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    319.8±4.37ms        ? ?/sec    1.00    319.7±2.81ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    206.6±2.30ms        ? ?/sec    1.00    207.2±2.17ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00   457.8±10.32ms        ? ?/sec    1.01   460.9±11.19ms        ? ?/sec

Copy link

codspeed-hq bot commented May 20, 2024

CodSpeed Performance Report

Merging #1180 will create unknown performance changes

Comparing 05-21-fix_should_generate_correct_chunk_import_path_to_importee_in_importer_chunk (3e815f7) with main (9204e6d)

Summary

🆕 6 new benchmarks

Benchmarks breakdown

Benchmark main 05-21-fix_should_generate_correct_chunk_import_path_to_importee_in_importer_chunk Change
🆕 threejs-bundle N/A 838.3 ms N/A
🆕 threejs-scan N/A 637.2 ms N/A
🆕 threejs-sourcemap N/A 1.1 s N/A
🆕 threejs10x-bundle N/A 8.7 s N/A
🆕 threejs10x-scan N/A 6.4 s N/A
🆕 threejs10x-sourcemap N/A 11.3 s N/A

Copy link
Member Author

hyf0 commented May 20, 2024

Merge activity

  • May 20, 1:19 PM EDT: @hyf0 started a stack merge that includes this pull request via Graphite.
  • May 20, 1:20 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 20, 1:21 PM EDT: @hyf0 merged this pull request with Graphite.

Base automatically changed from 05-20-chore_rust_unite_using_filename_instead_of_file_name_ to main May 20, 2024 17:20
@hyf0 hyf0 force-pushed the 05-21-fix_should_generate_correct_chunk_import_path_to_importee_in_importer_chunk branch from be6ceb5 to 3e815f7 Compare May 20, 2024 17:20
Copy link

netlify bot commented May 20, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3e815f7
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/664b864f1238f60008d77d24

@hyf0 hyf0 merged commit 8190a5c into main May 20, 2024
22 checks passed
@hyf0 hyf0 deleted the 05-21-fix_should_generate_correct_chunk_import_path_to_importee_in_importer_chunk branch May 20, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant