chore: CR for #1103

[hyf0]

Description

CR for #1103

[codecov]

Codecov Report

Attention: Patch coverage is 96.42857% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.88%. Comparing base (e9938d9) to head (66d0a81).
Report is 27 commits behind head on fix/dce-package-json.

❗ Current head 66d0a81 differs from pull request most recent head 7116c9b

Please upload reports for the commit 7116c9b to get more accurate results.

Files	Patch %	Lines
crates/rolldown_common/src/types/side_effects.rs	90.00%	3 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                    @@
##           fix/dce-package-json    #1179      +/-   ##
========================================================
+ Coverage                 86.70%   86.88%   +0.17%     
========================================================
  Files                       123      124       +1     
  Lines                      6109     6235     +126     
========================================================
+ Hits                       5297     5417     +120     
- Misses                      812      818       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hyf0]

Though I used stable_resource_id, which is a relatived path to cwd, I think it's also ok we use absolute path resource_id.

[github-actions]

Benchmarks Rust

• target: fix/dce-package-json(f6f3eb5)
• pr: hyf_3299492304(c7cdd8c)

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     30.1±0.50ms        ? ?/sec    1.06     31.9±0.65ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     21.5±1.08ms        ? ?/sec    1.05     22.5±0.30ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.00     43.7±3.03ms        ? ?/sec    1.02     44.8±1.15ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    322.9±3.41ms        ? ?/sec    1.03    333.8±3.46ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    213.7±1.96ms        ? ?/sec    1.03    220.9±2.12ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    460.1±9.44ms        ? ?/sec    1.01    463.2±8.75ms        ? ?/sec

Benchmarks Rust

• target: fix/dce-package-json(f6f3eb5)
• pr: hyf_3299492304(4a35ec9)

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     29.8±0.35ms        ? ?/sec    1.02     30.3±0.26ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     21.8±0.97ms        ? ?/sec    1.02     22.1±0.34ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.00     42.8±1.68ms        ? ?/sec    1.00     42.8±0.65ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    319.5±2.98ms        ? ?/sec    1.03    328.8±2.57ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    211.1±2.26ms        ? ?/sec    1.03    217.1±0.99ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    459.3±8.25ms        ? ?/sec    1.01   461.9±11.03ms        ? ?/sec

Benchmarks Rust

• target: fix/dce-package-json(f6f3eb5)
• pr: hyf_3299492304(66d0a81)

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     29.9±0.30ms        ? ?/sec    1.03     30.7±0.29ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     21.4±0.71ms        ? ?/sec    1.04     22.3±0.16ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.00     42.7±1.03ms        ? ?/sec    1.01     43.1±0.98ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    315.9±1.84ms        ? ?/sec    1.05   332.2±14.16ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    206.1±1.70ms        ? ?/sec    1.05    217.3±1.25ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    457.1±9.58ms        ? ?/sec    1.00   457.4±10.19ms        ? ?/sec

Benchmarks Rust

• target: fix/dce-package-json(f6f3eb5)
• pr: hyf_3299492304(7116c9b)

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.03     30.4±0.25ms        ? ?/sec    1.00     29.6±0.29ms        ? ?/sec
rolldown benchmark/threejs-scan            1.02     21.3±0.52ms        ? ?/sec    1.00     21.0±0.65ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.06     43.5±2.84ms        ? ?/sec    1.00     41.1±0.56ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    316.7±1.83ms        ? ?/sec    1.00    316.8±3.81ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    205.9±1.43ms        ? ?/sec    1.00    205.9±3.88ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.02   449.2±11.72ms        ? ?/sec    1.00    441.1±6.71ms        ? ?/sec

[codspeed-hq]

CodSpeed Performance Report

Merging #1179 will not alter performance

_{Comparing hyf_3299492304 (7116c9b) with hyf_3299492304 (66d0a81)}

Summary

✅ 6 untouched benchmarks