Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Event content type should use Smart Date fields, not datetime_range #69

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mandclu
Copy link

@mandclu mandclu commented May 13, 2024

As per the discussion in #64, convert the Event content type to use a Smart Date field, and set the default value to "next hour".

@phenaproxima phenaproxima changed the title Event field smart date The Event content type should use Smart Date fields, not datetime_range May 13, 2024
@phenaproxima
Copy link
Owner

phenaproxima commented May 16, 2024

Just FYI -- I cannot merge this because it's not installing. This is the error we're getting: https://github.com/phenaproxima/starshot-prototype/actions/runs/9071250306/job/24967409796?pr=69#step:5:791

Probably some misconfiguration in the fields. @mandclu, if you can address this I or another maintainer can manually test and hopefully merge this.

@mandclu
Copy link
Author

mandclu commented May 16, 2024

OK I'll try to have a look tomorrow

@mandclu mandclu requested a review from phenaproxima May 16, 2024 05:18
@mandclu
Copy link
Author

mandclu commented May 16, 2024

I believe the issue was the field values in the demo content. I added a commit to convert them.

@phenaproxima
Copy link
Owner

Looks like there's a bug in the module here, @mandclu...bad enough that it prevents installation. Can you address that? I'll need to at least manually test this before I can merge it.

@mandclu
Copy link
Author

mandclu commented May 25, 2024

I added a commit and then tested the result on a fresh install. The updated recipe worked without issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants