-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CI workflow to confirm that Starshot can be spun up with DDEV. #58
Conversation
@phenaproxima, by way of review... This is my read of your intentions. Is it accurate? The job runs...
I have a concern that the behavior when combining |
@TravisCarden I feel like it should be a separate workflow, but how about this: what if we simply trigger it:
...and forget the scheduling, and manual dispatches? |
That seems wiser to me, @phenaproxima. 👍 |
13bb342
to
00610f0
Compare
Okay, @phenaproxima. It appears that GitHub Actions will only run a dependent workflow (i.e., one that's triggered by another one) when it's on the main branch. And it seems like it always runs the version of the dependent one that's on the main branch--at least that's what my testing suggests so far. I don't know what that will mean for pull requests that change the new workflow. But I'm going to go ahead and merge this just to get it in the main branch where I can confirm that it's working. We can create follow-ups as needed. |
Following up #50. We should really confirm continuously that Starshot works with DDEV.