Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI workflow to confirm that Starshot can be spun up with DDEV. #58

Merged
merged 5 commits into from
May 31, 2024

Conversation

phenaproxima
Copy link
Owner

Following up #50. We should really confirm continuously that Starshot works with DDEV.

@TravisCarden
Copy link
Collaborator

TravisCarden commented May 10, 2024

@phenaproxima, by way of review... This is my read of your intentions. Is it accurate?

The job runs...

  • on...
    • pushes to main or wip
    • pull requests to main
  • or every 12 hours on the main branch only
  • or when triggered manually
  • but only after the "Main" workflow run is complete

I have a concern that the behavior when combining workflow_run with schedule or workflow_dispatch is unspecified and may lead to unexpected or variable results. It would be much safer (and simpler) to make this a separate step in the "Main" workflow instead of a whole separate workflow. Since you're running it on all the same triggers as "Main", the effect would be essentially the same. The only argument against it would be if you need to be able to run just the "DDEV" workflow without the "Main" workflow--though even that could be effectively done by canceling individual jobs on the presumably rare occasion you would want to do it. So that's what I recommend. What do you think?

@phenaproxima
Copy link
Owner Author

phenaproxima commented May 13, 2024

@TravisCarden I feel like it should be a separate workflow, but how about this: what if we simply trigger it:

  • only on main, and PRs to main
  • only when the Main workflow has succeeded

...and forget the scheduling, and manual dispatches?

@TravisCarden
Copy link
Collaborator

That seems wiser to me, @phenaproxima. 👍

@phenaproxima phenaproxima added this to the GA milestone May 16, 2024
@TravisCarden TravisCarden force-pushed the ddev-ci branch 2 times, most recently from 13bb342 to 00610f0 Compare May 30, 2024 22:13
@TravisCarden
Copy link
Collaborator

Okay, @phenaproxima. It appears that GitHub Actions will only run a dependent workflow (i.e., one that's triggered by another one) when it's on the main branch. And it seems like it always runs the version of the dependent one that's on the main branch--at least that's what my testing suggests so far. I don't know what that will mean for pull requests that change the new workflow. But I'm going to go ahead and merge this just to get it in the main branch where I can confirm that it's working. We can create follow-ups as needed.

@TravisCarden TravisCarden merged commit a8c5ce2 into main May 31, 2024
5 checks passed
@TravisCarden TravisCarden deleted the ddev-ci branch May 31, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants