Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Pokemon Info screen from being covered up #1156

Conversation

knispeja
Copy link
Contributor

@knispeja knispeja commented May 20, 2024

Prevents the yes/no confirm menu from getting in the way when the Pokemon Info screen is open when catching a new Pokemon with a full party. Maybe subjective whether or not this is improved but I think it's nicer this way since you can actually read the ability and nature completely.

Before:

PokemonInfoImprovementBefore.mp4

After:

PokemonInfoImprovementAfter.mp4

Prevents the yes/no confirm menu from getting in the way when the Pokemon Info screen is open when catching a new Pokemon
@knispeja knispeja changed the title Move Pokemon info screen when confirming Prevent Pokemon Info screen from being covered up May 20, 2024
@bennybroseph
Copy link
Collaborator

bennybroseph commented May 20, 2024

Thinking on it, this is actually a good solution. With the window slid to the left you can now also see money/floor/etc. I'd like to see it either occur faster or have the "Yes" "No" prompt tween alpha to make it fit in more. The later is definitely outside the scope of this PR though.

Also, was this tested on different resolutions/mobile?

@bennybroseph bennybroseph self-requested a review May 20, 2024 09:22
@bennybroseph bennybroseph self-assigned this May 20, 2024
@bennybroseph bennybroseph added the enhancement New feature or request label May 20, 2024
@karl-police
Copy link
Contributor

Animation faster, definitely. Like very fast. It's like u ask me a question and I have to respond with "Yes" or "No", and the response needs to be served NOW, type of thing.

@karl-police
Copy link
Contributor

Thinking on it, this is actually a good solution. With the window slid to the left you can now also see money/floor/etc. I'd like to see it either occur faster or have the "Yes" "No" prompt tween alpha to make it fit in more. The later is definitely outside the scope of this PR though.

Also, was this tested on different resolutions/mobile?

UI Function documentation when

@Tempo-anon
Copy link
Collaborator

Whoa sliding the whole window to the left, pretty cool. I know that can help alleviate issues I've heard users complain about such as the HP and defense IVs being covered up by other UI components

@knispeja
Copy link
Contributor Author

knispeja commented May 20, 2024

Also, was this tested on different resolutions/mobile?

I did try several window sizes (up to 4k) on desktop and did the same in Chrome's Device Mode thing to emulate mobile -- it seems like this game always renders at the same aspect ratio though so I'm not too worried

I'd like to see it either occur faster or have the "Yes" "No" prompt tween alpha to make it fit in more.

Good idea, I sped it up quite a bit and experimented with different ease functions. Looking for feedback on which one people like better (or something else, maybe, from Phaser's easing functions):

Cubic.easeInOut - this is what was already being used, I just sped it up a lot

CubicEaseInOut.mp4

Back.easeOut - a little weird, but this one gives the feeling that the confirm menu "knocks" the Pokemon info screen out of the way, I kind of like it

BackEase.mp4

@bennybroseph
Copy link
Collaborator

I think we should go with the sped up Cubic.easeInOut . The other one is cool, but none of our other animations match this. Maybe something to consider, but not for this PR

@knispeja
Copy link
Contributor Author

I think we should go with the sped up Cubic.easeInOut

Done! It's currently using that cubic example from my previous comment.

@bennybroseph
Copy link
Collaborator

man, i love little polish things like this

@bennybroseph bennybroseph merged commit 6016ecf into pagefaultgames:main May 21, 2024
1 check passed
@knispeja knispeja deleted the improvePokemonInfoContainerVisibility branch May 22, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants