-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Pokemon Info screen from being covered up #1156
Prevent Pokemon Info screen from being covered up #1156
Conversation
Prevents the yes/no confirm menu from getting in the way when the Pokemon Info screen is open when catching a new Pokemon
Thinking on it, this is actually a good solution. With the window slid to the left you can now also see money/floor/etc. I'd like to see it either occur faster or have the "Yes" "No" prompt tween alpha to make it fit in more. The later is definitely outside the scope of this PR though. Also, was this tested on different resolutions/mobile? |
Animation faster, definitely. Like very fast. It's like u ask me a question and I have to respond with "Yes" or "No", and the response needs to be served NOW, type of thing. |
UI Function documentation when |
Whoa sliding the whole window to the left, pretty cool. I know that can help alleviate issues I've heard users complain about such as the HP and defense IVs being covered up by other UI components |
I did try several window sizes (up to 4k) on desktop and did the same in Chrome's Device Mode thing to emulate mobile -- it seems like this game always renders at the same aspect ratio though so I'm not too worried
Good idea, I sped it up quite a bit and experimented with different ease functions. Looking for feedback on which one people like better (or something else, maybe, from Phaser's easing functions):
CubicEaseInOut.mp4
BackEase.mp4 |
I think we should go with the sped up |
Done! It's currently using that cubic example from my previous comment. |
man, i love little polish things like this |
Prevents the yes/no confirm menu from getting in the way when the Pokemon Info screen is open when catching a new Pokemon with a full party. Maybe subjective whether or not this is improved but I think it's nicer this way since you can actually read the ability and nature completely.
Before:
PokemonInfoImprovementBefore.mp4
After:
PokemonInfoImprovementAfter.mp4