Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few new lines up to be localized from in battle.ts locales #1144

Merged
merged 34 commits into from
May 23, 2024
Merged

Few new lines up to be localized from in battle.ts locales #1144

merged 34 commits into from
May 23, 2024

Conversation

Adri1
Copy link
Contributor

@Adri1 Adri1 commented May 20, 2024

No description provided.

@Tempo-anon Tempo-anon added the Localization Provides or updates translation efforts label May 20, 2024
@Adri1
Copy link
Contributor Author

Adri1 commented May 20, 2024

German translations added

SavGRY
SavGRY reviewed May 21, 2024
View reviewed changes
src/locales/it/battle.ts Outdated Show resolved Hide resolved
SavGRY
SavGRY reviewed May 21, 2024
View reviewed changes
Copy link

@SavGRY SavGRY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got some of the italian translation for the new added dialogues

src/locales/it/battle.ts Outdated Show resolved Hide resolved
src/locales/it/battle.ts Outdated Show resolved Hide resolved
src/locales/it/battle.ts Outdated
@@ -12,7 +13,9 @@ export const battle: SimpleTranslationEntries = {
"trainerGo": "{{trainerName}} manda in campo {{pokemonName}}!",
"switchQuestion": "Vuoi cambiare\n{{pokemonName}}?",
"trainerDefeated": `Hai sconfitto\n{{trainerName}}!`,
"moneyWon": "You got\n₽{{moneyAmount}} for winning!",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation in Italian would be: Hai vinto {{moneyAmount}}₽

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation got by BDSP

@Adri1
Copy link
Contributor Author

Adri1 commented May 21, 2024

Suggested Italian translations added

@Adri1
Copy link
Contributor Author

Adri1 commented May 21, 2024 •
edited

A check from an admin would be very welcome! 👌

@Adri1
Copy link
Contributor Author

Adri1 commented May 23, 2024 •
edited

@bennybroseph It is possible to have review on this one or there is an issue I do not know?
Asking because I tend to see very recent localiztion PR being reviewed and merged very quickly (or at least quicker), while some others like this one are still the queue for some days for no apparent reason. (I'm also thinking about PR #1150 )

@bennybroseph
Copy link
Collaborator

it's just hard to get to everything. with localization, things that don't change any game code can be merged pretty much immediately. things that add new localization take a review and sometimes when I look at it I don't have time to test

@bennybroseph bennybroseph merged commit 79af115 into pagefaultgames:main May 23, 2024
2 checks passed
@Adri1 Adri1 deleted the rogue-battle-sentences-update branch May 29, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeTappert CodeTappert CodeTappert left review comments

@SavGRY SavGRY SavGRY left review comments

@GhostFlys GhostFlys GhostFlys approved these changes

@bennybroseph bennybroseph bennybroseph approved these changes

Assignees
No one assigned
Labels
Localization Provides or updates translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Adri1 @bennybroseph @GhostFlys @CodeTappert @SavGRY @Tempo-anon