Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repel Implementation - Trainer battle chance #1123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FedericoRossiIT
Copy link

@FedericoRossiIT FedericoRossiIT commented May 19, 2024

Added repels for increased trainer battle chance

I had to delete the previous fork so also the previous pull request.
In the previous pull request I prevented double battles, now I changed the implementation thanks to a comment in the previous pull request saying something along the lines of 'Adding repels preventing double battle would be bloat (it will make lures and repels go in conflict)'.

ps. Still need these translations: de, es, fr, pt_BR, zh_CN

Added repels for increased trainer battle chance
@CodeTappert
Copy link
Contributor

CodeTappert commented May 19, 2024

De Translation:

 "TrainerBattleChanceBoosterModifierType": {
      description: "Verdoppelt für {{battleCount}} Kämpfe die Chance auf einen Trainerkampf",
    },

 "REPEL": { name: "Schutz" },
    "SUPER_REPEL": { name: "Superschutz" },
    "MAX_REPEL": { name: "Top-Schutz" },

@LeCehlou
Copy link

LeCehlou commented May 19, 2024

French locale

"TrainerBattleChanceBoosterModifierType": {
     description: "Double les chances de rencontrer un dresseur pendant {{battleCount}} combats",
   },

"REPEL": { name: "Repousse" },
   "SUPER_REPEL": { name: "Super Repousse" },
   "MAX_REPEL": { name: "Repousse Max" },

@bennybroseph bennybroseph added the enhancement New feature or request label May 19, 2024
@LeCehlou
Copy link

I'm not yet familiar with the pokerogue code, but I don't think you prevent the items to show in endless where there is non trainer battles.

Added fr and de locales
@FedericoRossiIT
Copy link
Author

I've added fr and de locales as given.

I'm not yet familiar with the pokerogue code, but I don't think you prevent the items to show in endless where there is non trainer battles.

There was already a check that if in the game config the property hasTrainers is false it will give a wild encounter: if (!this.gameMode.hasTrainers)

@LeCehlou
Copy link

I've added fr and de locales as given.

I'm not yet familiar with the pokerogue code, but I don't think you prevent the items to show in endless where there is non trainer battles.

There was already a check that if in the game config the property hasTrainers is false it will give a wild encounter: if (!this.gameMode.hasTrainers)

Perfect !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants