-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Firebreather trainer class #1102
Conversation
Have you tested it at all? |
I tried, I checked all errors marked by npm and fixed them but I can't get to open the localhost page |
Ok I opened inspect and notified another error, going to fix it |
Now the game opens in localhost:8000, I'll test when a firebreather battle pops in |
Is there a way to force a trainer battle to ocur in debug to save time? |
Seems okay to me. No dialogue though? |
I've implemented dialogue now |
Trainer spawns correctly in Volcano, and seems to work right. |
I'll take a look at dialogues from Pokémon HGSS (where the Firebreather trainer class originates from) to implement into the trainer class |
I've added some more dialogue lines |
src/data/dialogue.ts
Outdated
victory: [ | ||
`If we only had it warmer.`, | ||
`I flamed out.` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get one more victory dialogue to balance out the encounter and victory count?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I added a 3rd dialogue now
As a test to how this engine works I wanted to start by adding a trainer class