Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Firebreather trainer class #1102

Closed
wants to merge 0 commits into from
Closed

Conversation

Alekemon
Copy link
Contributor

As a test to how this engine works I wanted to start by adding a trainer class

@chacolah
Copy link
Contributor

Have you tested it at all?

@Alekemon
Copy link
Contributor Author

Have you tested it at all?

I tried, I checked all errors marked by npm and fixed them but I can't get to open the localhost page

@Alekemon
Copy link
Contributor Author

Ok I opened inspect and notified another error, going to fix it

@Alekemon
Copy link
Contributor Author

Now the game opens in localhost:8000, I'll test when a firebreather battle pops in

@bennybroseph bennybroseph marked this pull request as draft May 19, 2024 12:16
@bennybroseph bennybroseph added the enhancement New feature or request label May 19, 2024
@Alekemon Alekemon marked this pull request as ready for review May 19, 2024 12:35
@Alekemon Alekemon marked this pull request as draft May 19, 2024 12:35
@Alekemon
Copy link
Contributor Author

Is there a way to force a trainer battle to ocur in debug to save time?

@Alekemon Alekemon marked this pull request as ready for review May 19, 2024 14:08
@Alekemon
Copy link
Contributor Author

1

Now it works as intended

@Tempo-anon
Copy link
Collaborator

Seems okay to me. No dialogue though?

@Alekemon
Copy link
Contributor Author

I've implemented dialogue now

src/data/dialogue.ts Outdated Show resolved Hide resolved
@LaukkaE
Copy link
Collaborator

LaukkaE commented May 19, 2024

Trainer spawns correctly in Volcano, and seems to work right.
Could use more dialogue if available.

@Alekemon
Copy link
Contributor Author

Trainer spawns correctly in Volcano, and seems to work right. Could use more dialogue if available.

I'll take a look at dialogues from Pokémon HGSS (where the Firebreather trainer class originates from) to implement into the trainer class

@Alekemon
Copy link
Contributor Author

I've added some more dialogue lines

@Alekemon Alekemon requested a review from LaukkaE May 20, 2024 17:49
victory: [
`If we only had it warmer.`,
`I flamed out.`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get one more victory dialogue to balance out the encounter and victory count?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I added a 3rd dialogue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants