Added A Toggle For The IV Scanner In The Style Of Lock Capsule

[Simplyfenton]

Fairly certain this is a feature that a lot of players want (myself included)

Added the toggle to the shop on the bottom right hand side, to mirror that of the Lock Capsule.

It's certainly not the prettiest implementation, and the logic could likely be compacted from what I've got, but in fairness to me, I did start making this at 8am.

(Any feedback and stuff would be great, first time contributing to a public project like this)

[CodeTappert]

Please add images showing it.

[karl-police]

Will Conflict with #1074

Thing is mine has also the option to force scan, not with the animation, but I think I could add the animation to it now but, meh. And it's not located at the end of a battle.

 

When I first, got the idea to add that. I realized that adding a Toggle simply isn't enough. What's the point of being able to toggle it. You don't know what Pokemon you encounter next. But giving the ability to Force Scan as well. Now that one, is a pog.

[Simplyfenton]

Please add images showing it.

The text being red indicates that the IV Scanner is currently disabled.

When I first, got the idea to add that. I realized that adding a Toggle simply isn't enough. What's the point of being able to toggle it. You don't know what Pokemon you encounter next. But giving the ability to Force Scan as well. Now that one, is a pog.

I think a "force scan" is something that would likely be useful, but as it stands, I don't think there's anywhere that it would go within the battle UI that would "fit", and it certainly wouldn't belong in the standard menu. Since neither the Lock Capsule or this IV Scanner setting are saved, refreshing the page would re-enable the IV Scanner at the start of the current battle which, while not ideal, is an option before a wider discussion about the "force scan"'s implementation. I don't know how many people I speak for, but I personally wouldn't mind not having the force scan option - the upside of not having the dialogue boxes at the beggining of every non-trainer battle is then balanced by the downside of not having that information to hand readily.

[CodeTappert]

Definitly it can not be that color.
It is really hard to read that way. (But maybe its my red color deficency). There is not.enough contrast between the text and the Background

[karl-police]

Please add images showing it.

The text being red indicates that the IV Scanner is currently disabled.

When I first, got the idea to add that. I realized that adding a Toggle simply isn't enough. What's the point of being able to toggle it. You don't know what Pokemon you encounter next. But giving the ability to Force Scan as well. Now that one, is a pog.

I think a "force scan" is something that would likely be useful, but as it stands, I don't think there's anywhere that it would go within the battle UI that would "fit", and it certainly wouldn't belong in the standard menu. Since neither the Lock Capsule or this IV Scanner setting are saved, refreshing the page would re-enable the IV Scanner at the start of the current battle which, while not ideal, is an option before a wider discussion about the "force scan"'s implementation. I don't know how many people I speak for, but I personally wouldn't mind not having the force scan option - the upside of not having the dialogue boxes at the beggining of every non-trainer battle is then balanced by the downside of not having that information to hand readily.

I believe that with additions that allow flexibility in the code itself, to quickly change how it is implemented, shouldn't bring a worry on where it is currently put at.

The IV-Scanner is just one of current things. If I'd toggle the IV-Scanner off, and I encounter a Pokemon that I do want to scan, then one is simply just screwed. But you can re-open the game and then just scan it, that's true.

Then there is the issue at where to put it. I could ask myself, HOW many players, would toggle it off, and never toggle it on again? 🤔 But the toggle button will still show up there.

What if there's other things in the future, other than the IV-Scanner. @CodeTappert had the idea to change Balls to Bags, which I do like and the original game does have.

But then right now, there'd just be "Balls" and "IV-Scanner" inside of it. 🤷

[Simplyfenton]

Definitly it can not be that color. It is really hard to read that way. (But maybe its my red color deficency). There is not.enough contrast between the text and the Background

Yeah, I largely just picked the colour so that it'd be obvious that it's off, it's the same white as the rest of the text when the IV Scanner is enabled. Realistically, a dulled grey might work well, wasn't something I particularly looked into though.

[Simplyfenton]

Updated the toggled colour so that it now displays in Grey rather than Red, quite a bit more readable now.

[CodeTappert]

Updated the toggled colour so that it now displays in Grey rather than Red, quite a bit more readable now.

Way better! :)

[Simplyfenton]

Just bumping this for any potential feedback/thoughts

[karl-police]

Currently, a lot are thinkering about this #783 and testing

[Simplyfenton]

Resolved Conflicts in Phases.ts

[Simplyfenton]

Fixed linting issues that I evidently didn't fix previously