fix: load non relative tsconfig #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another solution would be to use tsconfck for tsconfig resolution - it resolves extends automatically and without issues. |
|
Let's use tsconfck 🙏 |
|
Is there anyone following up this? Same issue here #267 |
|
I'll update the PR with new implementation today |
|
Oops, just implemented. Apologies! |
|
Not a problem, it wasn't that easy for me to squeeze that one today - I guess I'll do the maintenance somewhere else 😄 |
Not matter, Thanks for your great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #267 (at least in some cases)
Currently, the
loadTSCompilerOptionsmethod does not handle correctlytsconfig.json"extends"field when it contains reference to an npm package.Examples of such
"extends":"extends": "@something/my-config/tsconfig.json""extends": "@something/my-config/base.json""extends": "@something/my-config"With this change the script handles those cases correctly and (at least for me) fixes issue #267