New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support TypeScript config using tsx #18440
Draft
antfu
wants to merge
6
commits into
eslint:main
Choose a base branch
from
antfu:feat/ts-config
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cli
Relates to ESLint's command-line interface
core
Relates to ESLint's core APIs and features
labels
May 10, 2024
✅ Deploy Preview for docs-eslint canceled.
|
Co-authored-by: aryaemami59 <aryaemami59@users.noreply.github.com>
fasttime
added
the
needs design
Important details about this change need to be discussed
label
May 11, 2024
6 tasks
Marking as a draft to avoid accidental merging, as there is an RFC being discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cli
Relates to ESLint's command-line interface
core
Relates to ESLint's core APIs and features
feature
This change adds a new feature to ESLint
needs design
Important details about this change need to be discussed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
tsx
instead ofjiti
Support loading
eslint.config.ts
eslint.config.mts
eslint.config.cts
files powered bytsx
. The support is opt-in by users, where they need to installtsx
explicitly (we include it as optional peer deps instead ofdependencies
)Based on my previous experiments with
eslint-ts-patch
(which supports swapping different loaders likejiti
tsx
bundle-require
, feel free to try them out). So for I see thattsx
is the best approach as it uses Node's native loader API, support full ESM, top-level await, and does not generate temporary files.The only downside is that it uses Node's API, which has only been available since
v20.8.0
andv18.19.0
. But considering this is an opt-in feature, it should be fine, and the ecosystem should catch up soon.Is there anything you'd like reviewers to focus on?