Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long timeout label handling #171385

Merged
merged 1 commit into from May 11, 2024
Merged

Remove long timeout label handling #171385

merged 1 commit into from May 11, 2024

Conversation

carlocab
Copy link
Member

This shouldn't be needed anymore after Homebrew/ci-orchestrator#13.

This shouldn't be needed anymore after Homebrew/ci-orchestrator#13.
@carlocab carlocab requested review from MikeMcQuaid and a team as code owners May 10, 2024 16:58
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels May 10, 2024
@carlocab
Copy link
Member Author

I'll be around tomorrow to make sure this is working as intended post-merge.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again @carlocab, excited to see this land!

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks!

Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlocab!

@carlocab
Copy link
Member Author

Merging now. Next we probably want to handle setting long time outs more carefully by separating out long build from long deps tests.

@carlocab carlocab added this pull request to the merge queue May 11, 2024
Merged via the queue into master with commit 290ddfc May 11, 2024
20 checks passed
@carlocab carlocab deleted the new-long-build-flow branch May 11, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants