kubectl-rook-ceph 0.8.0 (new formula) #171289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
autosquash
chenrui333
changed the title
chenrui333
reviewed
May 9, 2024
chenrui333
reviewed
May 9, 2024
Skaronator
force-pushed
the
rook-plugin
branch
4 times, most recently
from
169c3b8
to
5f8af9b
Compare
github-actions
bot
added
autosquash
github-actions
bot
removed
the
autosquash
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
Skaronator
force-pushed
the
rook-plugin
branch
2 times, most recently
from
ed4ea1c
to
23cf064
Compare
chenrui333
reviewed
May 9, 2024
chenrui333
reviewed
May 9, 2024
chenrui333
reviewed
May 9, 2024
chenrui333
reviewed
May 9, 2024
github-actions
bot
added
the
autosquash
github-actions
bot
removed
the
autosquash
Skaronator
force-pushed
the
rook-plugin
branch
2 times, most recently
from
029404b
to
f512339
Compare
5 tasks
chenrui333
force-pushed
the
rook-plugin
branch
2 times, most recently
from
2ebc1d9
to
a300aab
Compare
github-actions
bot
added
the
automerge-skip
|
Looks like there is some build discrepancy with goreleaser build, raise a PR in here, rook/kubectl-rook-ceph#290 |
5 tasks
carlocab
approved these changes
May 12, 2024
chenrui333
approved these changes
May 18, 2024
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
need a rebase laster for the autobump part |
Adds binary with the normal kubectl plugin naming of "kubectl-rook_ceph" Co-authored-by: Rui Chen <rui@chenrui.dev> kubectl-rook-ceph: minor updates Signed-off-by: Rui Chen <rui@chenrui.dev> autobump: add kubectl-rook-ceph Signed-off-by: Rui Chen <rui@chenrui.dev>
carlocab
approved these changes
May 18, 2024
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This adds the Rook.io CLI Plugin.
Main Repo: https://github.com/rook/rook
Plugin Repo: https://github.com/rook/kubectl-rook-ceph
While this go binary doesn't need kubectl to run, it's the recommended way of interacting with this tool. The name of the binary must be "kubectl-rook_ceph" in order for kubectl to find it correctly.
https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/#naming-a-plugin