Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipopt: add mumps headers to install #171266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnwparent
Copy link

@johnwparent johnwparent commented May 9, 2024

  • [x ] Have you followed the guidelines for contributing?
  • [x ] Have you ensured that your commits follow the commit style guide?
  • [x ] Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

From #154418

Alternative to adding Mumps to brew directly

@github-actions github-actions bot added the java Java use is a significant feature of the PR or issue label May 9, 2024
# install headers
libexec.install "include"
(libexec/"include").install Dir["libseq/*.h"]
include.install_symlink Dir[libexec/"include/*"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just directly installing them into include instead of installing into libexec and then creating symlinks?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to differentiate core ipopt headers from headers vendored from a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Java use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants