Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsontoolkit 2.0.0 (new formula) #171151

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

tony-go
Copy link
Contributor

@tony-go tony-go commented May 8, 2024

Hi there 馃憢馃徏

We'd like to add https://github.com/sourcemeta/jsontoolkit to homebrew :)

I followed the guide. I hope I did not forget anything.

Cheers.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Thanks for contributing to Homebrew! 馃帀 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@carlocab carlocab changed the title Add jsontoolkit 2.0.0 jsontoolkit 2.0.0 (new formula) May 8, 2024
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 8, 2024
@tony-go
Copy link
Contributor Author

tony-go commented May 8, 2024

I just saw this from Linux CI:

audit --formula jsontoolkit --online --new output
  jsontoolkit
    * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
  Error: 1 problem in 1 formula detected.

Something I did not get locally. 馃

@tony-go
Copy link
Contributor Author

tony-go commented May 8, 2024

Thanks for your review @carlocab :)

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label May 8, 2024
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 added the notability Project is not notable enough for inclusion label May 8, 2024
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
@tony-go tony-go requested a review from carlocab May 15, 2024 08:52
Formula/j/jsontoolkit.rb Outdated Show resolved Hide resolved
@tony-go
Copy link
Contributor Author

tony-go commented May 16, 2024

hey @chenrui333 @carlocab 馃憢馃徏

How does notability issues are handled, generally speaking?

@chenrui333
Copy link
Member

looks like there are some outstanding comments?

@chenrui333
Copy link
Member

@tony-go also can you squash the commits and add the formula into autobump.txt? Thanks!

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels May 22, 2024
@tony-go
Copy link
Contributor Author

tony-go commented May 22, 2024

I did a mistake with my rebase :/ let me fix it.

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 22, 2024
@tony-go
Copy link
Contributor Author

tony-go commented May 22, 2024

@chenrui333 It should be good now :)

Thanks for your review.

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label May 24, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 24, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 24, 2024
Merged via the queue into Homebrew:master with commit 068db99 May 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants