Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weasis 4.4.0 (new cask) #173325

Merged
merged 1 commit into from May 12, 2024
Merged

weasis 4.4.0 (new cask) #173325

merged 1 commit into from May 12, 2024

Conversation

nroduit
Copy link
Contributor

@nroduit nroduit commented May 9, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@krehel
Copy link
Member

krehel commented May 9, 2024

Hi @nroduit - thank you for opening this PR! I've pushed some fixes to help with the PR, but you may need to investigate your x86_64 pkg build - it failed to install in CI and I also attempted to install locally without success.

@krehel krehel added the awaiting user reply Issue needs response from a user. label May 9, 2024
@nroduit
Copy link
Contributor Author

nroduit commented May 11, 2024

Hi @nroduit - thank you for opening this PR! I've pushed some fixes to help with the PR, but you may need to investigate your x86_64 pkg build - it failed to install in CI and I also attempted to install locally without success.

I do not understand where is the issue onx86_64 pkg because in GUI it will be installed without any issues. In CLI I got an error installer: Error - Weasis can’t be installed on this computer. without more information (even in debug mode).
Do you have another suggestion for solving this problem?

@krehel
Copy link
Member

krehel commented May 11, 2024

I did not use Homebrew for local testing to verify it was not a CI issue with the x86_64 pkg. I downloaded the package directly from GitHub and it did not install using normal pkg install method.

I also tested with the 4.3.0 pkg on Intel and it did install / run without issue. 4.4.0 did not.

@krehel
Copy link
Member

krehel commented May 11, 2024

It appears the 4.4.0 release for Intel is actually built for Apple Silicon. Differences between 4.3.0 and 4.4.0 below.

4.3.0
weasis 4 3 0

4.4.0
weasis 4 4 0

@nroduit
Copy link
Contributor Author

nroduit commented May 12, 2024

It appears the 4.4.0 release for Intel is actually built for Apple Silicon. Differences between 4.3.0 and 4.4.0 below.

Thanks for your support.
As I no longer have x86 hardware, I was testing on arm64 hardware and I just noticed that the mac-latest runner on GitHub has changed from x86 to arm64.

@krehel
Copy link
Member

krehel commented May 12, 2024

Thanks. You aren't the first person to have this occur regarding the runner switch to arm64. Glad to help.

@krehel krehel changed the title weasis 4.4.0 weasis 4.4.0 (new cask) May 12, 2024
@krehel krehel removed the awaiting user reply Issue needs response from a user. label May 12, 2024
@miccal
Copy link
Member

miccal commented May 12, 2024

Thank you @nroduit.

@miccal miccal merged commit f77688a into Homebrew:master May 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants