Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix TitleState bugs + crash #2539

Merged
merged 1 commit into from
May 29, 2024
Merged

[BUGFIX] Fix TitleState bugs + crash #2539

merged 1 commit into from
May 29, 2024
+5 −3

Conversation

gamerbross
Copy link
Contributor

Fixes TitleState in general

  • When going back to TitleState, the music gets muted
  • Spamming enter when getting to TitleState crashed (wasn't initialized yet)
  • No 1 second black screen when going back to TitleState

@EliteMasterEric EliteMasterEric changed the base branch from main to develop May 17, 2024 23:05
@ninjamuffin99 ninjamuffin99 added this to the 0.4.0 milestone May 24, 2024
@ninjamuffin99 ninjamuffin99 self-requested a review May 24, 2024 20:18
@ninjamuffin99
Copy link
Member

code looks good! will test to double check

@EliteMasterEric EliteMasterEric merged commit 934d6c2 into FunkinCrew:develop May 29, 2024
@EliteMasterEric EliteMasterEric self-assigned this May 29, 2024
@gamerbross gamerbross deleted the bugfix/titlestate-startintro-crash branch May 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninjamuffin99 ninjamuffin99 Awaiting requested review from ninjamuffin99

Assignees

@EliteMasterEric EliteMasterEric

Labels
reviewing-internally
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gamerbross @ninjamuffin99 @EliteMasterEric