Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strumline / Notes background dim + Number preferences #2380

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

prplnorangesoda
Copy link

@prplnorangesoda prplnorangesoda commented May 9, 2024

I made a background dim option because my eyes aren't what they used to be and it started getting harder to see the arrows against the background. Other than that, it's a pretty nice accessibility option, for those who'd rather focus on the gameplay over the art (but why would you?) Up to y'all how much you want the max amount of dim to be if merged, I set it to 100% opaque.

Because I wanted this to be a preference, I engineered in a hacky TextMenuItem wrapper that lets you increment a number with a single key.

(not selected)

image

(selected)

image

(in-game)

image

This also comes with a bunch of written documentation for some pre-existing functions because VSCode was yelling at me lmao

this is an incredibly hacky PR. would love comments of improvements.

Note: THIS WILL BREAK ON BLAZIN! Here's an example commit to assets/preload/scripts/songs/blazin.hxc if this is merged that will fix it.

To-do:

  • Configurable option
    -- (Note: You can only go up, and you can't adjust the increment. I wanna address that)
  • Actual object to adjust alpha of in PlayState (possibly in hoveringStuff?)
    -- PlayState.instance.strumlineBackground

@prplnorangesoda
Copy link
Author

prplnorangesoda commented May 9, 2024

also I need help undoing some submodule changes because I'm a dumb stupid idiot and was testing with image assets before landing on text-only and I don't know how to undo my changes to a submodule 😭😭

the submodule conflict has been fixed

@prplnorangesoda prplnorangesoda changed the title Background dim + Number preferences Strumline / Notes background dim + Number preferences May 10, 2024
@prplnorangesoda
Copy link
Author

Commit history is dirty because of rebase (i branched off main instead of develop)

@prplnorangesoda prplnorangesoda marked this pull request as ready for review May 10, 2024 03:09
@amyspark-ng
Copy link

very cool

@ninjamuffin99
Copy link
Member

I'll keep this open but I will say off the top of my own head right now, this might be an unplanned feature for now. If you see me close this, it means it's definitely unplanned (as I would have consulted with others on da game design side of crew)

@prplnorangesoda
Copy link
Author

prplnorangesoda commented May 15, 2024

That's fine. I'll open it as an enhancement issue if this PR is closed if that's okay I'll rewrite this as a mod and publish it on my own if it's closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants