-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strumline / Notes background dim + Number preferences #2380
base: develop
Are you sure you want to change the base?
Strumline / Notes background dim + Number preferences #2380
Conversation
the submodule conflict has been fixed |
…nkin into backgroundDim
Commit history is dirty because of rebase (i branched off |
very cool |
patch blazin middlescroll to work with strumline background
I'll keep this open but I will say off the top of my own head right now, this might be an unplanned feature for now. If you see me close this, it means it's definitely unplanned (as I would have consulted with others on da game design side of crew) |
That's fine. |
I made a background dim option because my eyes aren't what they used to be and it started getting harder to see the arrows against the background. Other than that, it's a pretty nice accessibility option, for those who'd rather focus on the gameplay over the art (but why would you?) Up to y'all how much you want the max amount of dim to be if merged, I set it to 100% opaque.
Because I wanted this to be a preference, I engineered in a hacky
TextMenuItem
wrapper that lets you increment a number with a single key.(not selected)
(selected)
(in-game)
This also comes with a bunch of written documentation for some pre-existing functions because VSCode was yelling at me lmao
this is an incredibly hacky PR. would love comments of improvements.
Note: THIS WILL BREAK ON BLAZIN! Here's an example commit to
assets/preload/scripts/songs/blazin.hxc
if this is merged that will fix it.To-do:
-- (Note: You can only go up, and you can't adjust the increment. I wanna address that)
--
PlayState.instance.strumlineBackground