Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some lifecycle hooks apis #216

Open
Ubugeeei opened this issue May 19, 2024 · 1 comment
Open

fix some lifecycle hooks apis #216

Ubugeeei opened this issue May 19, 2024 · 1 comment
Labels
bug Something isn't working runtime test wontfix This will not be worked on

Comments

@Ubugeeei
Copy link
Member

relates #215

There seem to be some points where the behavior differs from the original.
I added FIXME comments in packages/runtime-vapor/tests/apiLifecycle.spec.ts.
@Ubugeeei Ubugeeei added bug Something isn't working wontfix This will not be worked on runtime test labels May 19, 2024
@Ubugeeei Ubugeeei changed the title fix some lifecycle hooks api's fix some lifecycle hooks apis May 19, 2024
@Ubugeeei Ubugeeei mentioned this issue May 19, 2024
Merged
2 tasks
@LittleSound
Copy link
Member

LittleSound commented May 21, 2024 •
edited

This issue looks like it's related to PR #123 ?

I've created new BlockEffectScope and createChildFragmentDirectives functions that I hope will help make it easier to implement Lifecycle Hooks in Vapor. such as the lifecycle in slots or in components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working runtime test wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LittleSound @Ubugeeei