-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement NormalizedInputOptions
and NormalizedOutputOptions
to rust side
#1041
Comments
I also think about it before, we could using original I‘m worried if we remove the |
I think about this too. But it requires us to change the definition of
About this I said above
In fact, the current |
Why
The main problem is that the concept
NormalizedInputOptions
is try to give a final form of options while it still in Js side not passing to the rust.Take
external
option as an example,NormalizedInputOptions
requireexternal
option to be afunction
, which means though users passed static['external']
data and it would still needs be wrapped in a js function, that's bad for performance. Ifexternal
option is setted, every resolve process would need to call Js function in sequence.How
I looked into the ``NormalizedInputOptions` and delete we highly not going to support. We got
The problem here is that for properties whose value is function is complicated/impossible to pass them from rust to js, so we only have
I kind of feel this is enough for compatibility support. I hardly think of the situation the users want to "have" the function in the
NormalizedInputOptions
and do something with it. Unless they want to do something hacky, but that's not our scope.The above analysis also applies on
NormalizedOutputOptions
. As long as we don't consider properties whose value is function, it's all fine.As a bonus:
The text was updated successfully, but these errors were encountered: