Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for more oEmbed providers #57

Open
mayankguptadotcom opened this issue May 9, 2024 · 6 comments
Open

Support for more oEmbed providers #57

mayankguptadotcom opened this issue May 9, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@mayankguptadotcom
Copy link

At this point, remote video is a media type that offers YouTube & Vimeo out of the box. However, if we are focused on Marketers, editors and non-developers - then support for more external oEmbed providers will be important for the goal that we want to achieve. WordPress supports multiple oEmbed providers by default and here's a list of those -

  1. Soundcloud
  2. Spotify
  3. Flickr
  4. Animoto
  5. Cloudup
  6. Crowdsignal
  7. Dailymotion
  8. imgur
  9. issuu
  10. kickstarter
  11. mixcloud
  12. pocket casts
  13. reddit
  14. reverbnation
  15. screencast
  16. scribd
  17. slideshare
  18. smugmug
  19. speaker deck
  20. tiktok
  21. TED
  22. Tumblr
  23. Videopress
  24. amazon kindle
  25. pinterest
  26. wolfram

I'm not saying that we need to support these to compete against WordPress - but we should support more than YouTube & Vimeo, it should certainly help improve the usability for editors. One module that does a great job to extend the support for various oEmbed providers is https://www.drupal.org/project/oembed_providers

@mayankguptadotcom
Copy link
Author

Few other important ones that should be included -

  1. github
  2. google docs

@mayankguptadotcom
Copy link
Author

Another thing that I noticed was that when I pasted a youtube link in ckEditor demo over here - https://ckeditor.com/docs/ckeditor5/latest/examples/builds-custom/full-featured-editor.html

It embedded the video directly, rather than me to create a remote video. There may be benefits to include remote video as a content type, however - I believe that content editors for marketing purpose will not really care about that in majority of the cases. So I'd rather suggest supporting this kind of embedding with in the ckEditor more.

image

@phenaproxima
Copy link
Owner

I am +1 on adding the oEmbed Providers module, but I think we should carefully select which providers we enable. It's really easy to go overboard, and we also need to group the providers into particular media types that make sense.

So I'd propose in this issue we discuss and agree on which providers should be supported, and in which media types (including ones that might not exist yet) -- let's say a maximum of, like, 6 providers, to avoid overwhelm.

@phenaproxima phenaproxima added the enhancement New feature or request label May 9, 2024
@mayankguptadotcom
Copy link
Author

Absolutely agreed. Definitely not a huge list - but the most used ones in real world scenarios. Here's my suggested list -

  1. Google docs
  2. Github
  3. YouTube
  4. Vimeo
  5. SoundCloud
  6. Issuu
  7. Flickr
  8. Reddit

Not sure if Google docs & Github offer oEmbed (the chances are they don't based on my initial research), although embedly seems to (paid service) allow to embed them as well. If we can't do Google docs & Github due to technical limitations then its okay - in that case we have the 6 providers that you are suggesting.

@macburgee1
Copy link

The oEmbed Providers module would be honored!

I'm thinking Starshot could define its own provider bucket, along with any providers that aren't included in providers.json from oembed.com

@kopeboy
Copy link

kopeboy commented May 11, 2024

Isn't Spotify more popular than SoundCloud?
And what about X (former Twitter)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants