fix: allow empty default message (#1849)

intlify · May 11, 2024 · 4b231ce · 4b231ce
1 parent c14ad03
commit 4b231ce
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/packages/core-base/src/translate.ts b/packages/core-base/src/translate.ts
@@ -649,8 +649,11 @@ export function translate<
         : (!messageCompiler ? () => key : key)
       : fallbackFormat // default by `fallbackFormat` option
         ? (!messageCompiler ? () => key : key)
-        : ''
-  const enableDefaultMsg = fallbackFormat || defaultMsgOrKey !== ''
+        : null
+  const enableDefaultMsg =
+    fallbackFormat ||
+    (defaultMsgOrKey != null &&
+      (isString(defaultMsgOrKey) || isFunction(defaultMsgOrKey)))
   const locale = getLocale(context, options)
 
   // escape params

diff --git a/packages/core-base/test/translate.test.ts b/packages/core-base/test/translate.test.ts
@@ -120,6 +120,7 @@ describe('default option', () => {
     expect(translate(ctx, 'hello', 'hello, default message!')).toEqual(
       'hello, default message!'
     )
+    expect(translate(ctx, 'hello', '')).toEqual('')
   })
 
   test('boolean true', () => {

diff --git a/packages/vue-i18n-core/test/composer.test.ts b/packages/vue-i18n-core/test/composer.test.ts
@@ -734,6 +734,16 @@ describe('t', () => {
     await nextTick()
     expect(t('hello')).toEqual(JA_HELLO)
   })
+
+  test('default msg', () => {
+    const { t } = createComposer({
+      locale: 'en',
+      messages: {
+        en: { hello: 'Hello!' }
+      }
+    })
+    expect(t('foo', '')).toEqual('')
+  })
 })
 
 describe('rt', () => {