-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Best way to set MUJOCO_GL #55
Comments
IMO we should avoid making the user export env variables at almost all costs (it's cumbersome, and if you have a policy of allowing it, there will be more). Questions:
|
I agree, it's probably not good practice
Env variables set in the script only live in the script's execution environment and don't persist in the shell after execution so this should be fine.
For sure, I'll try to narrow down these conditions to see where it would be best to set it (in case we go with option 2) |
Something like this should do ok: huggingface/gym-xarm@4c65f3e |
Is it addressed? @aliberts |
|
Right now, some online training won't work when the env uses mujoco if the environment variable
MUJOCO_GL
has not been set toegl
.Since there's no indication for that in the current README, I'm creating this issue to discuss the best way to address this moving forward. Here are the 2 ways that I see for how we could solve this:
1. Explicitly tell the user in the README to set it:
export MUJOCO_GL=egl
2. Set it directly in the code (and make it invisible to the user):
I don't really know what's the best way here. What do you think @Cadene @alexander-soare?
The text was updated successfully, but these errors were encountered: