Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogReader doesn't work with non-continguous segments #32035

Open
adeebshihadeh opened this issue Mar 28, 2024 · 1 comment
Open

LogReader doesn't work with non-continguous segments #32035

adeebshihadeh opened this issue Mar 28, 2024 · 1 comment

Comments

@adeebshihadeh
Copy link
Contributor

Needs a better error and some way to just get whatever segments are present

batman:debug$ ./count_events.py "4baf26681af2f7bd/2024-03-27--21-27-36"
Traceback (most recent call last):
  File "/home/batman/openpilot/selfdrive/debug/./count_events.py", line 23, in <module>
    for msg in LogReader(sys.argv[1], ReadMode.QLOG):
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/batman/openpilot/openpilot/tools/lib/logreader.py", line 256, in __init__
    self.reset()
  File "/home/batman/openpilot/openpilot/tools/lib/logreader.py", line 279, in reset
    self.logreader_identifiers = self._parse_identifiers(self.identifier)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/batman/openpilot/openpilot/tools/lib/logreader.py", line 239, in _parse_identifiers
    identifiers = source(sr, mode)
                  ^^^^^^^^^^^^^^^^
  File "/home/batman/openpilot/openpilot/tools/lib/logreader.py", line 191, in auto_source
    raise Exception(f"auto_source could not find any valid source, exceptions for sources: {exceptions}")
Exception: auto_source could not find any valid source, exceptions for sources: [AssertionError(), AssertionError(), AssertionError(), AssertionError()]
@sshane
Copy link
Contributor

sshane commented Mar 28, 2024

/a does get whatever segments are present (by falling back to qlogs). FYI error message was more clear here: #31484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants